Re: [PATCH v5 13/19] arm64: Make the PHYS_MASK_SHIFT dynamic
From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2024-08-26 10:31:27
Also in:
kvm, kvmarm, linux-coco, lkml
From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2024-08-26 10:31:27
Also in:
kvm, kvmarm, linux-coco, lkml
On Mon, Aug 19, 2024 at 02:19:18PM +0100, Steven Price wrote:
Make the PHYS_MASK_SHIFT dynamic for Realms. This is only is required for masking the PFN from a pte entry.
Unless my grep failed, pte_pfn() hasn't used PHYS_MASK for many years,
since commit 75387b92635e ("arm64: handle 52-bit physical addresses in
page table entries").
Can you check what pte_pfn() returns on a shared page?
Unless we need this macro for other things, I'm more tempted to clear
the bit in __pte_to_phys().
--
Catalin