在 2024/8/23 23:27, Andy Shevchenko 写道:

[Some people who received this message don't often get email from andriy.shevchenko@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Wed, Aug 21, 2024 at 02:49:58PM +0800, Yu Jiaoliang wrote:

quoted

Let the kememdup_array() take care about multiplication and possible

kmemdup_array()

quoted

overflows.

...

quoted

+     dup_configs = kmemdup_array(configs, num_configs, sizeof(*dup_configs),
+                                 GFP_KERNEL);

I would even make this a single line.

...

quoted

+     dup_configs = kmemdup_array(configs, num_configs, sizeof(*dup_configs),
+                                 GFP_KERNEL);

Ditto.

--
With Best Regards,
Andy Shevchenko

Hi Andy,

I have reformatted the code and submitted patch v2. Thank you.

Best Regards,

Yu