Re: rtc: at91sam9: fix OF node leak in probe() error path

On Mon, Aug 26, 2024 at 09:12:32AM +0200, Markus Elfring wrote:

quoted

quoted

quoted

Driver is leaking an OF node reference obtained from
of_parse_phandle_with_fixed_args().

Is there a need to improve such a change description another bit?

+ Imperative mood

…

quoted

Commit msg is fine.

…

quoted

quoted

+ Tags like “Fixes” and “Cc”

Read the patch.

What does hinder you to take requirements from a known information source
better into account?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc5#n94

Regards,
Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot