Thread (29 messages) 29 messages, 7 authors, 2024-08-23

Re: [PATCH v2] gpio: rockchip: Set input direction when request irq

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2024-08-23 14:59:08
Also in: linux-gpio, linux-rockchip, lkml

On Fri, Aug 23, 2024 at 11:43:12AM +0800, Ye Zhang wrote:
Since the GPIO can only generate interrupts when its direction is set to
input, it is set to input before requesting the interrupt resources.
...
+	rockchip_gpio_direction_input(&bank->gpio_chip, d->hwirq);
+
 	return gpiochip_reqres_irq(&bank->gpio_chip, d->hwirq);
In both cases you want to use irq_hw_number_t and irqd_to_hwirq() at the top of
the function(s).

-- 
With Best Regards,
Andy Shevchenko


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help