Thread (15 messages) 15 messages, 3 authors, 2024-09-12

Re: [PATCH v3 07/10] drm/tegra: gr3d: Convert into devm_pm_domain_attach_list()

From: Thierry Reding <hidden>
Date: 2024-08-23 11:53:32
Also in: linux-pm, lkml

On Fri, Aug 23, 2024 at 12:45:44AM GMT, Ulf Hansson wrote:
Rather than hooking up the PM domains through devm_pm_opp_attach_genpd()
and manage the device-link, let's avoid the boilerplate-code by converting
into devm_pm_domain_attach_list().

Signed-off-by: Ulf Hansson <redacted>
---

Changes in v3:
	- Updated commitmsg.
	- Converted to devm mangaged version of dev_pm_domain_attach_list()

---
 drivers/gpu/drm/tegra/gr3d.c | 38 +++++++-----------------------------
 1 file changed, 7 insertions(+), 31 deletions(-)
I'm not very familiar with most of the OPP bits in this driver, but it
looks like the corresponding code is now in the core, so this seems
fine:

Acked-by: Thierry Reding <redacted>

On a related note: we have two other case on Tegra where we attach to
multiple PM domains (drivers/usb/host/xhci-tegra.c and
drivers/usb/gadget/udc/tegra-xudc.c). Both of those don't use OPP, but
I wonder if they could also be simplified using the new
devm_pm_domain_attach_list() function?

Thierry

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help