Re: [PATCH 4/7] memory: pl172: simplify with dev_err_probe()
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Date: 2024-08-23 11:46:51
Also in:
linux-omap, lkml
On Fri, 23 Aug 2024 12:15:59 +0200 Krzysztof Kozlowski [off-list ref] wrote:
Use dev_err_probe() to avoid dmesg flood on actual defer. This makes the code also simpler. Signed-off-by: Krzysztof Kozlowski <redacted>
FWIW Reviewed-by: Jonathan Cameron <redacted>
quoted hunk ↗ jump to hunk
--- drivers/memory/pl172.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)diff --git a/drivers/memory/pl172.c b/drivers/memory/pl172.c index 9eb8cc7de494..390012401f64 100644 --- a/drivers/memory/pl172.c +++ b/drivers/memory/pl172.c@@ -217,10 +217,9 @@ static int pl172_probe(struct amba_device *adev, const struct amba_id *id) return -ENOMEM; pl172->clk = devm_clk_get(dev, "mpmcclk"); - if (IS_ERR(pl172->clk)) { - dev_err(dev, "no mpmcclk provided clock\n"); - return PTR_ERR(pl172->clk); - } + if (IS_ERR(pl172->clk)) + return dev_err_probe(dev, PTR_ERR(pl172->clk), + "no mpmcclk provided clock\n"); ret = clk_prepare_enable(pl172->clk); if (ret) {