Thread (14 messages) 14 messages, 3 authors, 2024-08-21

Re: [PATCH v2 1/3] phy: phy-rockchip-inno-usb2: Perform trivial code cleanups

From: Dragan Simic <hidden>
Date: 2024-08-21 08:53:17
Also in: linux-phy, linux-rockchip, lkml

Hello Heiko,

On 2024-08-21 10:39, Heiko Stübner wrote:
Am Mittwoch, 21. August 2024, 09:37:53 CEST schrieb Dragan Simic:
quoted
Perform a few trivial code cleanups, e.g. to obey the reverse 
Christmas tree
rule, to avoid use of "{ ... }" code blocks where they aren't really 
needed,
or to avoid line wrapping by using the 100-column width better.

No intended functional changes are introduced by these code cleanups.

Signed-off-by: Dragan Simic <redacted>
quoted
@@ -445,7 +445,6 @@ static int rockchip_usb2phy_extcon_register(struct 
rockchip_usb2phy *rphy)
 	}

 	rphy->edev = edev;
-
 	return 0;
 }
depending on how nitpicky we want to be, I'm not very fond of this 
change.
Assigning the extcon-dev and returning "0" are two different actions, 
and
I think most drivers do actually use a blank line between those.

But that really is just a style preference for me, so anyway

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Thanks for your review; I had similar thoughts, believe it or not. :)  
If
there will be v3, I'll bring the empty separator line back.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help