Re: [PATCH 03/14] Input: samsung-keypad - do not combine memory allocation checks | linux-arm-kernel

[PATCH 00/14] Remove support for platform data from samsung keypad · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
[PATCH 01/14] Input: samsung-keypad - switch to using devm_clk_get_prepared() · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 01/14] Input: samsung-keypad - switch to using devm_clk_get_prepared() · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-19
Re: [PATCH 01/14] Input: samsung-keypad - switch to using devm_clk_get_prepared() · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
[PATCH 02/14] Input: samsung-keypad - do not set input device's parent explicitly · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 02/14] Input: samsung-keypad - do not set input device's parent explicitly · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-19
[PATCH 03/14] Input: samsung-keypad - do not combine memory allocation checks · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 03/14] Input: samsung-keypad - do not combine memory allocation checks · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-19
[PATCH 04/14] Input: samsung-keypad - use struct_size() helper · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 04/14] Input: samsung-keypad - use struct_size() helper · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-19
[PATCH 05/14] Input: samsung-keypad - use devm to disable runtime PM · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 05/14] Input: samsung-keypad - use devm to disable runtime PM · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-19
Re: [PATCH 05/14] Input: samsung-keypad - use devm to disable runtime PM · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
[PATCH 06/14] Input: samsung-keypad - use guard notation to acquire mutex · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 06/14] Input: samsung-keypad - use guard notation to acquire mutex · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-22
Re: [PATCH 06/14] Input: samsung-keypad - use guard notation to acquire mutex · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-22
Re: [PATCH 06/14] Input: samsung-keypad - use guard notation to acquire mutex · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-23
Re: [PATCH 06/14] Input: samsung-keypad - use guard notation to acquire mutex · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-23
Re: [PATCH 06/14] Input: samsung-keypad - use guard notation to acquire mutex · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-23
Re: [PATCH 06/14] Input: samsung-keypad - use guard notation to acquire mutex · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-23
[PATCH 07/14] Input: samsung-keypad - use per-chip parameters · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 07/14] Input: samsung-keypad - use per-chip parameters · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-19
[PATCH 08/14] Input: samsung-keypad - use BIT() and GENMASK() where appropriate · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
[PATCH 09/14] dt-bindings: input: samsung,s3c6410-keypad: introduce compact binding · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 09/14] dt-bindings: input: samsung,s3c6410-keypad: introduce compact binding · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-19
Re: [PATCH 09/14] dt-bindings: input: samsung,s3c6410-keypad: introduce compact binding · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 09/14] dt-bindings: input: samsung,s3c6410-keypad: introduce compact binding · Conor Dooley <conor@kernel.org> · 2024-08-19
Re: [PATCH 09/14] dt-bindings: input: samsung,s3c6410-keypad: introduce compact binding · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
[PATCH 10/14] Input: samsung-keypad - handle compact binding · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
[PATCH 11/14] ARM: s3c: crag6410: switch keypad device to software properties · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 11/14] ARM: s3c: crag6410: switch keypad device to software properties · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-22
[PATCH 12/14] Input: samsung-keypad - remove support for platform data · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
[PATCH 13/14] ARM: s3c: crag6410: use software nodes/properties to set up GPIO keys · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 13/14] ARM: s3c: crag6410: use software nodes/properties to set up GPIO keys · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-22
[PATCH 14/14] ARM: s3c: crag6410 - convert GPIO lookup tables to property entries · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-08-19
Re: [PATCH 14/14] ARM: s3c: crag6410 - convert GPIO lookup tables to property entries · Krzysztof Kozlowski <krzk@kernel.org> · 2024-08-22
Re: [PATCH 00/14] Remove support for platform data from samsung keypad · "Arnd Bergmann" <arnd@arndb.de> · 2024-08-19
Re: [PATCH 00/14] Remove support for platform data from samsung keypad · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-10-04
Re: [PATCH 00/14] Remove support for platform data from samsung keypad · Mark Brown <broonie@kernel.org> · 2024-10-04

Re: [PATCH 03/14] Input: samsung-keypad - do not combine memory allocation checks

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-08-19 12:52:25
Also in: linux-devicetree, linux-input, linux-samsung-soc, lkml

On Sun, Aug 18, 2024 at 09:58:00PM -0700, Dmitry Torokhov wrote:

The driver uses devm API to allocate resources so there's no reason
to do allocations first and then check and release everything at once.

Check results immediately after doing allocation of each resource.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/keyboard/samsung-keypad.c | 5 ++++-

Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help