RE: [PATCH 2/2] usb: dwc3: xilinx: add missing depopulate in probe error path
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
Date: 2024-08-14 10:31:59
Also in:
linux-omap, linux-usb, lkml, stable
-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: Wednesday, August 14, 2024 3:49 PM
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>; Greg Kroah-Hartman
[off-list ref]; Simek, Michal [off-list ref];
Grygorii Strashko [off-list ref]; Vignesh R [off-list ref];
Felipe Balbi [off-list ref]; Pandey, Radhey Shyam
[off-list ref]; Piyush Mehta
[off-list ref]; linux-usb@vger.kernel.org; linux-
omap@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <redacted>;
stable@vger.kernel.org
Subject: [PATCH 2/2] usb: dwc3: xilinx: add missing depopulate in probe
error path
Depopulate device in probe error paths to fix leak of children resources.
Fixes: 53b5ff83d893 ("usb: dwc3: xilinx: improve error handling for PM APIs")
Cc: <redacted>
Signed-off-by: Krzysztof Kozlowski <redacted>Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> Thanks!
quoted hunk ↗ jump to hunk
--- drivers/usb/dwc3/dwc3-xilinx.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index bb4d894c16e9..b7613a106da6 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c@@ -330,6 +330,7 @@ static int dwc3_xlnx_probe(struct platform_device*pdev) return pm_runtime_resume_and_get(dev); err_pm_set_suspended: + of_platform_depopulate(dev); pm_runtime_set_suspended(dev); err_clk_put: -- 2.43.0