-----Original Message-----
From: Rob Herring (Arm) <robh@kernel.org>
Sent: 2024年8月14日 0:33
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: shawnguo@kernel.org; linux-pci@vger.kernel.org;
devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
conor+dt@kernel.org; imx@lists.linux.dev; linux-kernel@vger.kernel.org;
kernel@pengutronix.de; l.stach@pengutronix.de; krzk+dt@kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
"atu" for i.MX8M PCIe Endpoint


On Tue, 13 Aug 2024 15:42:20 +0800, Richard Zhu wrote:

quoted

Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.

For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
driver. This method is not good.

In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
Frank suggests to fetch the dbi2 and atu from DT directly. This commit
is preparation to do that for i.MX8M PCIe EP.

These changes wouldn't break driver function. When "dbi2" and "atu"
properties are present, i.MX PCIe driver would fetch the according
base addresses from DT directly. If only two reg properties are
provided, i.MX PCIe driver would fall back to the old method.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml  | 13
+++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

Missing tags:

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Hi Rob:
Oops, I'm really sorry about that I missing this reviewed-by tag in v5 by
 my mistake.
Thank you very much for your notice and kindly help.

Hi Shawn:
Can you help to pick-up Rob's reviewed-by tag?
Thanks in advanced.

Best Regards
Richard Zhu