Thread (16 messages) read the whole thread 16 messages, 2 authors, 2024-08-13

Re: [PATCH 5/7] perf evlist: Use hybrid default attrs whenever extended type is supported

From: James Clark <james.clark@linaro.org>
Date: 2024-08-13 13:33:39
Also in: linux-perf-users, lkml


On 13/08/2024 2:23 pm, James Clark wrote:
For x86, a hybrid version of ___evlist__add_default_attrs() was added to
support default perf stat events. This can actually be used whenever
perf_pmus__supports_extended_type() is true, which now makes default
perf stat arguments work properly on Arm big.LITTLE:

   $ perf stat
   ...
         3347093940    armv8_cortex_a53/cycles/    #  0.563 GHz  (98.99%)
         3295523067    armv8_cortex_a57/cycles/    #  0.554 GHz  (67.07%)
   ...

Signed-off-by: James Clark <james.clark@linaro.org>
---
  tools/perf/arch/x86/util/evlist.c | 65 -------------------------------
  tools/perf/util/evlist.c          | 65 +++++++++++++++++++++++++++----
  tools/perf/util/evlist.h          |  6 +--
  3 files changed, 59 insertions(+), 77 deletions(-)
[...]
quoted hunk ↗ jump to hunk
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 1417f9a23083..e0c31399beb6 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -5,6 +5,7 @@
   * Parts came from builtin-{top,stat,record}.c, see those files for further
   * copyright notes.
   */
+#include "pmus.h"
Oops, this include was auto added and isn't required.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help