Thread (34 messages) 34 messages, 3 authors, 2024-08-14

Re: [PATCH 06/17] arm64: dts: layerscape: remove undocument big-endian in watchdog

From: Alexander Stein <hidden>
Date: 2024-08-13 08:31:27
Also in: imx, linux-devicetree, lkml

Am Dienstag, 13. August 2024, 06:35:01 CEST schrieb Frank Li:
quoted hunk ↗ jump to hunk
Remove undocument property big-endian in watchdog.
drivers/watchdog/imx2_wdt.c also never parser it.

Fix below wanring:
arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: watchdog@2ad0000:
	Unevaluated properties are not allowed ('big-endian' was unexpected)

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 -
 arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 -
 2 files changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index a3c57da63a01b..b84512bc4c881 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -430,7 +430,6 @@ wdog0: watchdog@2ad0000 {
 			reg = <0x0 0x2ad0000 0x0 0x10000>;
 			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(1)>;
-			big-endian;
RM LS1012A Rev3 10/2020 lists WDOG1 (2ad_0000) as big-endian.
quoted hunk ↗ jump to hunk
 		};
 
 		sai1: sai@2b50000 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index c0e3e8fa1e794..5837f1b15dccb 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -776,7 +776,6 @@ wdog0: watchdog@2ad0000 {
 			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
 					    QORIQ_CLK_PLL_DIV(1)>;
-			big-endian;
RM LS1043A Rev6 07/2020 lists WDOG1 (2ad_0000) as big-endian.

What about ls1021a? According to RM this is also big-endian.
regmap_get_val_endian() parses this property and regmap is used
by drivers/watchdog/imx2_wdt.c

Best regards,
Alexander

 		};
 
 		edma0: dma-controller@2c00000 {

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help