Thread (5 messages) 5 messages, 2 authors, 2024-08-08

Re: [PATCH v3 2/2] tty: serial: samsung_tty: cast the interrupt's void *id just once

From: Jiri Slaby <jirislaby@kernel.org>
Date: 2024-08-08 08:35:29
Also in: linux-samsung-soc, linux-serial, lkml

On 08. 08. 24, 10:11, André Draszik wrote:
The interrupt handler routines and helpers are casting the 'void *'
pointer to 'struct exynos_uart_port *' all over the place.

There is no need for that, we can do the casting once and keep passing
the 'struct exynos_uart_port *', simplifying the code and saving a few
lines of code.

No functional changes.

Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
v3: undo too eager removal of 'const' where unnecessary (Jiri)
LGTM now

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
v2: fix -Wdiscarded-qualifiers, sorry
thanks,
-- 
js
suse labs

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help