Thread (19 messages) 19 messages, 3 authors, 2024-08-08

Re: [PATCH v4 5/8] reset: mchp: sparx5: Allow building as a module

From: Steen Hegelund <steen.hegelund@microchip.com>
Date: 2024-08-07 09:16:48
Also in: linux-devicetree, linux-pci, lkml, netdev

Hi Herve,

On Mon, 2024-08-05 at 12:17 +0200, Herve Codina wrote:
quoted hunk ↗ jump to hunk
EXTERNAL EMAIL: Do not click links or open attachments unless you
know the content is safe

From: Clément Léger <clement.leger@bootlin.com>

This reset controller can be used by the LAN966x PCI device.

The LAN966x PCI device driver can be built as a module and this reset
controller driver has no reason to be a builtin driver in that case.

Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
 drivers/reset/Kconfig                  | 2 +-
 drivers/reset/reset-microchip-sparx5.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 5b5a4d99616e..88350aa8a51c 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -133,7 +133,7 @@ config RESET_LPC18XX
          This enables the reset controller driver for NXP
LPC18xx/43xx SoCs.

 config RESET_MCHP_SPARX5
-       bool "Microchip Sparx5 reset driver"
+       tristate "Microchip Sparx5 reset driver"
        depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI ||
COMPILE_TEST
        default y if SPARX5_SWITCH
        select MFD_SYSCON
diff --git a/drivers/reset/reset-microchip-sparx5.c
b/drivers/reset/reset-microchip-sparx5.c
index 636e85c388b0..69915c7b4941 100644
--- a/drivers/reset/reset-microchip-sparx5.c
+++ b/drivers/reset/reset-microchip-sparx5.c
@@ -158,6 +158,7 @@ static const struct of_device_id
mchp_sparx5_reset_of_match[] = {
        },
        { }
 };
+MODULE_DEVICE_TABLE(of, mchp_sparx5_reset_of_match);

 static struct platform_driver mchp_sparx5_reset_driver = {
        .probe = mchp_sparx5_reset_probe,
@@ -180,3 +181,4 @@ postcore_initcall(mchp_sparx5_reset_init);
 MODULE_DESCRIPTION("Microchip Sparx5 switch reset driver");
 MODULE_AUTHOR("Steen Hegelund [off-list ref]");
+MODULE_LICENSE("GPL");
--
2.45.0
Looks good to me.

Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>

BR
Steen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help