Re: [PATCH 1/1] arm64: dts: imx93: add lpi2c1 and child node
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-08-02 07:26:00
Also in:
imx, linux-devicetree, lkml
On 01/08/2024 18:09, Frank Li wrote:
From: Clark Wang <xiaoning.wang@nxp.com> Add lpi2c1 and child node for imx93-11x11-evk board.
Why? What for? What are these? We see all this from the diff, so commit msg should explain why and what do you want to achieve.
quoted hunk ↗ jump to hunk
Signed-off-by: Clark Wang <xiaoning.wang@nxp.com> Reviewed-by: Haibo Chen <haibo.chen@nxp.com> Signed-off-by: Li Yang <redacted> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Signed-off-by: Frank Li <Frank.Li@nxp.com> --- .../boot/dts/freescale/imx93-11x11-evk.dts | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts index a15987f49e8d6..dd387b820831a 100644 --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts@@ -145,6 +145,20 @@ ethphy2: ethernet-phy@2 { }; }; +&lpi2c1 { + #address-cells = <1>; + #size-cells = <0>; + clock-frequency = <400000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lpi2c1>; + status = "okay"; + + lsm6dsm@6a {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof