Hi Stephen, thanks for reviewing.

On Thu, 4 Jul 2024, at 11:02 AM, Stephen Boyd wrote:

Quoting Ryan Walklin (2024-07-03 03:51:09)

quoted

+#include <linux/of_address.h>

What is this include for?

for writel, however have confirmed this should instead be #include <asm/io.h>, will correct for v3.

quoted

+       if (of_device_is_compatible(pdev->dev.of_node,
+                                   "allwinner,sun50i-h616-de33-clk")) {
+               writel(0, reg + 0x24);
+               writel(0x0000A980, reg + 0x28);

Lowercase hex please. Did the downstream driver have names for these
register offsets by way of some sort of #define?

Thanks, will correct. AFAIK no, these are from Jernej's tree which I understand he developed independently, there was no vendor driver to reference, nor DE33 datasheet publicly available. 

Jernej, are you able to weigh in at all?

Thanks,

Ryan