Re: [PATCH v3 1/2] dt-bindings: media: imx335: Add reset-gpios to the DT example

On 31/07/2024 09:02, Umang Jain wrote:

It's easy to get the polarity of GPIOs in the device tree wrong, as
shown by a recently fixed bug in the imx335 driver. To lower the chance
of future mistakes, especially in new bindings that would take the
imx335 binding as a starting point, add the reset-gpios property to the
DT example. This showcases the correct polarity of the XCLR signal for
Sony sensors in the most common case of the signal not being inverted on
the board.

Just one sentence like - make the example complete by adding reset-gpios
with proper polarity - would be enough. Concise, yet still informative,
commit msgs are preferred, usually.

This device is not different than 1000 others which use GPIOs and for
every device you must use proper polarity. Commit msg suggests that here
we should explain something more.

Acked-by: Krzysztof Kozlowski <redacted>


Best regards,
Krzysztof