Re: [PATCH v2 6/6] dt-bindings: thermal: samsung,exynos: remove outdated information on trip point count

On Tue, Jul 30, 2024 at 11:17 AM Rob Herring [off-list ref] wrote:

On Fri, Jul 26, 2024 at 01:01:10PM +0200, Mateusz Majewski wrote:

quoted

This is not true as of commit 5314b1543787 ("thermal/drivers/exynos: Use
set_trips ops").

What is not true?

How can the h/w change? I already asked that. Please make your commit
message summarize prior discussions so that the patch stands on its own
and you don't get the same response again. Assume the reviewers have 0
recollection of the prior versions because we don't. This is just one of
100s of patches a week...

Hi Mateusz,

Do I understand it correctly that the patch actually removes an
outdated description of *driver* implementation, and not outdated
hardware description? If so, then maybe it makes sense to rework the
patch title and commit message in a way Rob suggests. I.e. rather than
stating that the patch removes an outdated information, instead
mention it removes *software* (driver) description which was
incorrectly added earlier. Because bindings are only meant for
hardware description and should be completely independent of driver's
side of things. Also in that case it probably doesn't make much sense
referencing that commit for using set_trips ops. Just my two cents.

Thanks!

[snip]