Re: [PATCH v3 3/4] rtc: stm32: add Low Speed Clock Output (LSCO) support
From: Linus Walleij <hidden>
Date: 2024-07-26 20:50:32
Also in:
linux-clk, linux-devicetree, linux-rtc, lkml
Hi Valentin, On Mon, Jul 22, 2024 at 6:02 PM Valentin Caron [off-list ref] wrote:
RTC is able to output on a pin the "LSE" internal clock. STM32 RTC is now registered as a clock provider. It provides rtc_lsco clock, that means RTC_LSCO is output on either RTC_OUT1 or RTC_OUT2_RMP, depending on pinmux DT property. The clock is marked as CLK_IGNORE_UNUSED and CLK_IS_CRITICAL because RTC_LSCO can be early required by devices needed it to init. Add LSCO in pinmux functions. Add "stm32_rtc_clean_outs" to disable LSCO. As RTC is part of "backup" power domain, it is not reset during shutdown or reboot. So force LSCO disable at probe. Co-developed-by: Amelie Delaunay <amelie.delaunay@foss.st.com> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com> Signed-off-by: Valentin Caron <redacted>
(...)
quoted hunk ↗ jump to hunk
@@ -1928,6 +1928,7 @@ config RTC_DRV_STM32 select PINMUX select PINCONF select GENERIC_PINCONF + depends on COMMON_CLK
Just select COMMON_CLK Why not, it will with 100% certainty be needed anyway by the system clock controller. Yours, Linus Walleij