Re: [PATCH] phy: exynos5-usbdrd: convert some FIELD_PREP_CONST() to FIELD_PREP()

On Fri, Jul 26, 2024 at 1:02 AM André Draszik [off-list ref] wrote:

Hi,

On Wed, 2024-07-10 at 07:45 +0100, André Draszik wrote:

quoted

Use of FIELD_PREP_CONST() was a thinko - it's meant to be used for
(constant) initialisers, not constant values.

Use FIELD_PREP() where possible. It has better error checking and is
therefore the preferred macro to use in those cases.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/phy/samsung/phy-exynos5-usbdrd.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Any comments on this patch?

Looks good to me:

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

Cheers,
Andre'