Thread (2 messages) 2 messages, 2 authors, 2024-08-02
STALE702d

[PATCH] crypto: arm64/poly1305 - move data to rodata section

From: Jia He <hidden>
Date: 2024-07-15 07:20:35
Also in: linux-crypto, lkml
Subsystem: arm64 port (aarch64 architecture), the rest · Maintainers: Catalin Marinas, Will Deacon, Linus Torvalds

When objtool gains support for ARM in the future, it may encounter issues
disassembling the following data in the .text section: 
.Lzeros:
.long   0,0,0,0,0,0,0,0
.asciz  "Poly1305 for ARMv8, CRYPTOGAMS by \@dot-asm"
.align  2
Move it to .rodata which is a more appropriate section for read-only data.

Signed-off-by: Jia He <redacted>
---
Inspired by commit 1253cab8a352, although currently objtool hasn't been
supported on Arm, we should do some preparation(this patch) firstly.

 arch/arm64/crypto/poly1305-armv8.pl | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/arch/arm64/crypto/poly1305-armv8.pl b/arch/arm64/crypto/poly1305-armv8.pl
index cbc980fb02e3..bcb70c9541e9 100644
--- a/arch/arm64/crypto/poly1305-armv8.pl
+++ b/arch/arm64/crypto/poly1305-armv8.pl
@@ -885,10 +885,13 @@ poly1305_blocks_neon:
 	ret
 .size	poly1305_blocks_neon,.-poly1305_blocks_neon
 
+.pushsection .rodata
 .align	5
 .Lzeros:
 .long	0,0,0,0,0,0,0,0
 .asciz	"Poly1305 for ARMv8, CRYPTOGAMS by \@dot-asm"
+.popsection
+
 .align	2
 #if !defined(__KERNEL__) && !defined(_WIN64)
 .comm	OPENSSL_armcap_P,4,4
-- 
2.34.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help