Thread (6 messages) 6 messages, 6 authors, 2024-08-04

Re: [PATCH] phy: exynos5-usbdrd: fix error code in probe()

From: Sam Protsenko <semen.protsenko@linaro.org>
Date: 2024-07-08 20:26:56
Also in: kernel-janitors, linux-phy, linux-samsung-soc, lkml

On Mon, Jul 8, 2024 at 12:04 PM Dan Carpenter [off-list ref] wrote:
Return negative -ENOMEM instead of positive ENOMEM.

Fixes: 497ddafe915e ("phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk")
Signed-off-by: Dan Carpenter <redacted>
---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
quoted hunk ↗ jump to hunk
 drivers/phy/samsung/phy-exynos5-usbdrd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
index df52b78a120b..9cbf90142950 100644
--- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
+++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
@@ -1745,7 +1745,7 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
                                           sizeof(*phy_drd->regulators),
                                           GFP_KERNEL);
        if (!phy_drd->regulators)
-               return ENOMEM;
+               return -ENOMEM;
        regulator_bulk_set_supply_names(phy_drd->regulators,
                                        drv_data->regulator_names,
                                        drv_data->n_regulators);
--
2.43.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help