Re: [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator
From: Andy Shevchenko <hidden>
Date: 2024-06-04 07:33:56
Also in:
linux-gpio
On Tue, Jun 4, 2024 at 10:28 AM Florian Fainelli [off-list ref] wrote:
On 6/3/2024 8:19 PM, Stefan Wahren wrote:
...
LGTM but sometimes I really wonder to what degree should we invent a helper function...
The rationale for the messaging is unification, that's why helpers like dev_err_probe() (for known non-deferred error codes), str_*() choices, and %pt (to have time and date be printed) are good to have. In general I agree that we should't become fanatics of hiding everything behind the macros and helpers. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel