Thread (5 messages) 5 messages, 3 authors, 2024-07-04

Re: [PATCH v1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-06-28 08:22:59
Also in: linux-clk, linux-devicetree, linux-rockchip, lkml

On 28/06/2024 10:13, Heiko Stübner wrote:
Hi Krzysztof,

Am Freitag, 28. Juni 2024, 09:27:14 CEST schrieb Krzysztof Kozlowski:
quoted
On 27/06/2024 23:17, Johan Jonker wrote:
quoted
CLK_NR_CLKS should not be part of the binding.
Remove since the kernel code no longer uses it.
Please wrap neither too early nor over the limit. Not one sentence per line.


quoted
Signed-off-by: Johan Jonker <redacted>
---
 include/dt-bindings/clock/rk3188-cru-common.h | 2 --
 1 file changed, 2 deletions(-)
diff --git a/include/dt-bindings/clock/rk3188-cru-common.h b/include/dt-bindings/clock/rk3188-cru-common.h
index afad90680fce..01e14ab252a7 100644
--- a/include/dt-bindings/clock/rk3188-cru-common.h
+++ b/include/dt-bindings/clock/rk3188-cru-common.h
@@ -132,8 +132,6 @@
 #define HCLK_VDPU		472
 #define HCLK_HDMI		473

-#define CLK_NR_CLKS		(HCLK_HDMI + 1)
I still see it as being used in linux-next. Some explanation is missing.
I think me applying Johan's patch [0] removing the constant's usage, simply
overlapped with yesterday's next-creation.
These should be sent in one patchset, which makes it obvious. Splitting
does not help...

Acked-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help