Re: [PATCH v2 4/5] dt-bindings: gpio: convert Atmel GPIO to json-schema
From: Conor Dooley <conor@kernel.org>
Date: 2024-06-25 16:34:45
Also in:
linux-devicetree, linux-gpio, lkml
On Tue, Jun 25, 2024 at 10:05:24AM +0530, Manikandan Muralidharan wrote:
quoted hunk ↗ jump to hunk
Convert the Atmel GPIO controller binding document to DT schema format using json-schema. The compatible string "microchip,sam9x7-gpio" is added as well. Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> --- changes in v2: - Fix bot errors with 'make dt_binding_check', missed to add "atmel,at91rm9200-gpio" as separate compatible for devices that uses it - Remove label from example - Add default entry for #gpio-lines property - Add new compatible string details in commit message --- .../bindings/gpio/atmel,at91rm9200-gpio.yaml | 81 +++++++++++++++++++ .../devicetree/bindings/gpio/gpio_atmel.txt | 31 ------- 2 files changed, 81 insertions(+), 31 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/atmel,at91rm9200-gpio.yaml delete mode 100644 Documentation/devicetree/bindings/gpio/gpio_atmel.txtdiff --git a/Documentation/devicetree/bindings/gpio/atmel,at91rm9200-gpio.yaml b/Documentation/devicetree/bindings/gpio/atmel,at91rm9200-gpio.yaml new file mode 100644 index 000000000000..3dd70933ed8e --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/atmel,at91rm9200-gpio.yaml@@ -0,0 +1,81 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/atmel,at91rm9200-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip GPIO controller (PIO) + +maintainers: + - Manikandan Muralidharan <manikandan.m@microchip.com> + +properties: + compatible: + oneOf: + - items: + - enum: + - atmel,at91sam9x5-gpio + - microchip,sam9x60-gpio + - const: atmel,at91rm9200-gpio + - items: + - enum: + - microchip,sam9x7-gpio + - const: microchip,sam9x60-gpio + - const: atmel,at91rm9200-gpio
It's worth pointing out that this is required, because the driver implements a different set of ops for the sam9x60. There's not just more of them, they're different too. Are the sam9x60 and at91rm9200 are actually compatible, or is the fallback here some mistake that originated in the dts?
Attachments
- signature.asc [application/pgp-signature] 228 bytes