Re: [PATCH 3/3] arm64: dts: rockchip: Add rkvdec2 Video Decoder on rk3588(s)

Hello all,

On 2024-06-16 11:17, Jonas Karlman wrote:

On 2024-06-15 21:55, Detlev Casanova wrote:

quoted

On Saturday, June 15, 2024 4:25:27 A.M. EDT Jonas Karlman wrote:

quoted

On 2024-06-15 03:56, Detlev Casanova wrote:

quoted

Add the rkvdec2 Video Decoder to the RK3588s devicetree.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---

 .../boot/dts/rockchip/rk3588-rock-5b.dts      |  4 ++++
 .../boot/dts/rockchip/rk3588s-orangepi-5.dts  |  4 ++++
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi     | 19 
+++++++++++++++++++
 3 files changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts

b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index
c551b676860c..965322c24a65 100644

--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts

@@ -503,6 +503,10 @@ &pwm1 {

 	status = "okay";

 };

+&rkvdec0 {
+	status = "okay";
+};

Enable of rkvdec0 should probably be split out from the patch that 
adds
the rkvdec0 node to soc dtsi.

Ack

quoted

Also why is rkvdec0 only enabled on rock-5b and orangepi-5?

I only could test on those two but I can enable it on all rk3588 
devices.

Because the decoder is an integrated part of the SoC the default should
probably be that the IP is enabled, i.e. no status prop required for 
the
vdec and related mmu nodes in rk3588s.dtsi.

Agreed, the decoder is a SoC feature.  As such, it should be enabled on
the SoC level, instead of having it enabled on the board level.