Re: [PATCH 2/3] pinctrl: rockchip: use dedicated pinctrl type for RK3328
From: Heiko Stübner <heiko@sntech.de>
Date: 2024-06-06 10:11:18
Also in:
linux-gpio, linux-rockchip, lkml
Am Donnerstag, 6. Juni 2024, 11:43:56 CEST schrieb Heiko Stübner:
Am Donnerstag, 6. Juni 2024, 08:04:34 CEST schrieb Huang-Huang Bao:quoted
rk3328_pin_ctrl uses type of RK3288 which has a hack in rockchip_pinctrl_suspend and rockchip_pinctrl_resume to restore GPIO6-C6 at assume, the hack is not applicable to RK3328 as GPIO6 is not even exist in it. So use a dedicated pinctrl type to skip this hack. Signed-off-by: Huang-Huang Bao <redacted>Reviewed-by: Heiko Stuebner <heiko@sntech.de>
I think this actually also warrants a Fixes-tag, because as you said, the
suspend handling for the rk3288 will change GRF registers it should not
touch on the rk3328.
Fixes: 3818e4a7678e ("pinctrl: rockchip: Add rk3328 pinctrl support")
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel