Re: [PATCH RFC v3 8/9] arm64: boot: dts: qcom: sm8550: Split into overlays
From: Krzysztof Kozlowski <hidden>
Date: 2024-06-05 08:20:16
Also in:
linux-arm-msm, linux-devicetree, lkml
On 21/05/2024 20:38, Elliot Berman wrote:
quoted hunk ↗ jump to hunk
+/dts-v1/; + +#include <dt-bindings/arm/qcom,ids.h> #include <dt-bindings/clock/qcom,rpmh.h> #include <dt-bindings/clock/qcom,sm8450-videocc.h> #include <dt-bindings/clock/qcom,sm8550-camcc.h>@@ -32,6 +35,11 @@ / { chosen { }; + board_id: board-id { + qcom,soc-version = <QCOM_ID_SM8550 QCOM_SOC_REVISION(1)>, + <QCOM_ID_SM8550 QCOM_SOC_REVISION(2)>; + };
I don't see how does it help to understand usage of board-id. You list all possible revisions, right? So this is entirely redundant. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel