Re: [PATCH] clkdev: report over-sized strings when creating clkdev entries

On Thu, May 02, 2024 at 09:02:16AM +0100, Russell King (Oracle) wrote:

On Wed, May 01, 2024 at 06:02:54PM -0700, Stephen Boyd wrote:

quoted

Quoting Stephen Boyd (2024-05-01 17:59:16)

quoted

Quoting Russell King (Oracle) (2024-03-15 04:47:55)

quoted

Report an error when an attempt to register a clkdev entry results in a
truncated string so the problem can be easily spotted.

Reported by: Duanqiang Wen [off-list ref]
Signed-off-by: Russell King (Oracle) <redacted>
---

Applied to clk-next

And backed out because I get a compilation failure

drivers/clk/clkdev.c: In function 'vclkdev_alloc':
drivers/clk/clkdev.c:182:17: error: function 'vclkdev_alloc' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
  182 |                 res = vsnprintf(cla->dev_id, sizeof(cla->dev_id), dev_fmt, ap);
      |                 ^~~
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:244: drivers/clk/clkdev.o] Error 1
make[4]: *** [scripts/Makefile.build:485: drivers/clk] Error 2

It builds fine for me. I don't get this _error_, and it's really no
different from what it originally was - instead of using vcsnprintf()
we're now using vsnprintf(). That should make no difference what so
ever.

... and I've just checked, and it builds entirely cleanly for me.

I'll merge it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel