Thread (14 messages) 14 messages, 5 authors, 2024-04-02

Re: [PATCH 1/7] mmc: sdio: store owner from modules with sdio_register_driver()

From: Francesco Dolcini <francesco@dolcini.it>
Date: 2024-03-31 20:37:32
Also in: linux-bluetooth, linux-mediatek, linux-mmc, linux-wireless, lkml

Hello Krzysztof,

On Fri, Mar 29, 2024 at 06:24:31PM +0100, Krzysztof Kozlowski wrote:
Modules registering driver with sdio_register_driver() might
forget to set .owner field.  The field is used by some of other kernel
                             ^^ double space here
parts for reference counting (try_module_get()), so it is expected that
drivers will set it.

Solve the problem by moving this task away from the drivers to the core
code, just like we did for platform_driver in
commit 9447057eaff8 ("platform_device: use a macro instead of
platform_driver_register").

Since many drivers forget to set the .owner, this effectively will fix
them.  Examples of fixed drivers are: ath6kl, b43, btsdio.c, ks7010,
       ^^ and here
libertas, MediaTek WiFi drivers, Realtek WiFi drivers, rsi, siano,
wilc1000, wl1251 and more.

Signed-off-by: Krzysztof Kozlowski <redacted>
My nit comments are irrelevant, but given you did the same twice I felt
like letting you know.

Reviewed-by: Francesco Dolcini <redacted>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help