Re: [PATCH 1/2] arm64: dts: rockchip: Add enable-strobe-pulldown to emmc phy on ROCK Pi 4
From: Dragan Simic <hidden>
Date: 2024-03-31 19:22:43
Also in:
linux-devicetree, linux-rockchip, lkml
On 2024-03-27 20:26, Folker Schwesinger wrote:
Commit 8b5c2b45b8f0 disabled the internal pull-down for the strobe line
causing I/O errors in HS400 mode for various eMMC modules.
Enable the internal strobe pull-down for ROCK Pi 4 boards. Also
re-enable
HS400 mode, that was replaced with HS200 mode as a workaround for the
stability issues in:
cee572756aa2 ("arm64: dts: rockchip: Disable HS400 for eMMC on ROCK Pi
4").
This was tested on ROCK 4SE and ROCK Pi 4B+.
Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in
dts")
Signed-off-by: Folker Schwesinger <redacted>Looking good to me. Reviewed-by: Dragan Simic <redacted>
quoted hunk ↗ jump to hunk
--- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsib/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi index 281a12180703..b9d6284bb804 100644--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi@@ -194,6 +194,7 @@ &cpu_b1 { }; &emmc_phy { + rockchip,enable-strobe-pulldown; status = "okay"; };@@ -648,7 +649,8 @@ &saradc { &sdhci { max-frequency = <150000000>; bus-width = <8>; - mmc-hs200-1_8v; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; non-removable; status = "okay"; };
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel