On 22/03/2024 20:12, Klymenko, Anatoliy wrote:

Hi Krzysztof,

Thanks a lot for the review.

quoted

-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: Thursday, March 21, 2024 10:59 PM
To: Klymenko, Anatoliy <redacted>; Laurent Pinchart
[off-list ref]; Maarten Lankhorst
[off-list ref]; Maxime Ripard [off-list ref];
Thomas Zimmermann [off-list ref]; David Airlie
[off-list ref]; Daniel Vetter [off-list ref]; Simek, Michal
[off-list ref]; Andrzej Hajda [off-list ref]; Neil
Armstrong [off-list ref]; Robert Foss [off-list ref]; Jonas
Karlman [off-list ref]; Jernej Skrabec [off-list ref]; Rob
Herring [off-list ref]; Krzysztof Kozlowski
[off-list ref]; Conor Dooley [off-list ref];
Mauro Carvalho Chehab [off-list ref]
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>; dri-
devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-
media@vger.kernel.org
Subject: Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings

Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.


On 21/03/2024 21:43, Anatoliy Klymenko wrote:

quoted

diff --git a/include/dt-bindings/media/media-bus-format.h b/include/dt-

bindings/media/media-bus-format.h

quoted

new file mode 100644
index 000000000000..60fc6e11dabc

--- /dev/null
+++ b/include/dt-bindings/media/media-bus-format.h

@@ -0,0 +1,177 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
+/*
+ * Media Bus API header
+ *
+ * Copyright (C) 2009, Guennadi Liakhovetski <g.liakhovetski@gmx.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.

That's not true. Your SPDX tells something entirely different.

Thank you - I'll see how to fix it.

quoted

Anyway, you did not explain why you need to copy anything anywhere.

Specifically, random hex values *are not bindings*.

The same media bus format values are being used by the reference driver in patch #9. And, as far as I know, we cannot use headers from Linux API headers directly (at least I 

I don't understand what does it mean. You can use in your driver
whatever headers you wish, I don't care about them.


noticed the same pattern in ../dt-bindings/sdtv-standarts.h for
instance). What would be the best approach to reusing the same defines
on DT and driver sides from your point of view? Symlink maybe?

Wrap your messages to match mailing list discussion style. There are no
defines used in DT. If there are, show me them in *THIS* or other
*upstreamed* (being upstreamed) patchset.

Whatever you have out of tree or "DO NOT MERGE" does not matter and does
not justify anything.


Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel