Re: [PATCH] dmaengine: owl: fix register access functions
From: Peter Korsgaard <peter@korsgaard.com>
Date: 2024-03-22 13:36:39
Also in:
dmaengine, lkml, llvm
quoted
quoted
quoted
quoted
"Arnd" == Arnd Bergmann [off-list ref] writes:
> From: Arnd Bergmann [off-list ref]
> When building with 'make W=1', clang notices that the computed register
> values are never actually written back but instead the wrong variable
> is set:
> drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 244 | u32 regval;
> | ^
> drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
> 268 | u32 regval;
> | ^
> Change these to what was most likely intended.
> Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
> Signed-off-by: Arnd Bergmann [off-list ref]
Good catch!
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel