Hi,

On Fri, Mar 22, 2024 at 05:53:07AM +0800, Sui Jingfeng wrote:

Hi,


On 2024/3/21 23:29, Maxime Ripard wrote:

quoted

Infoframes in KMS is usually handled by a bunch of low-level helpers
that require quite some boilerplate for drivers. This leads to
discrepancies with how drivers generate them, and which are actually
sent.

Now that we have everything needed to generate them in the HDMI
connector state, we can generate them in our common logic so that
drivers can simply reuse what we precomputed.

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
  drivers/gpu/drm/Kconfig                            |   1 +
  drivers/gpu/drm/drm_atomic_state_helper.c          | 338 +++++++++++++++++++++
  drivers/gpu/drm/drm_connector.c                    |  14 +
  .../gpu/drm/tests/drm_atomic_state_helper_test.c   |   1 +
  drivers/gpu/drm/tests/drm_connector_test.c         |  12 +
  include/drm/drm_atomic_state_helper.h              |   8 +
  include/drm/drm_connector.h                        | 109 +++++++
  7 files changed, 483 insertions(+)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 16029435b750..3d3193c7aa5f 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig

@@ -97,10 +97,11 @@ config DRM_KUNIT_TEST
  	  If in doubt, say "N".
  config DRM_KMS_HELPER
  	tristate
  	depends on DRM
+	select DRM_DISPLAY_HDMI_HELPER

Should we select DRM_DISPLAY_HELPER here? Otherwise there will have
some compile error emerged with default config.

Which default config are you talking about? This compiles fine with all
drm-misc defconfig, x86 defconfig and allmodconfig.

Maxime