Re: [PATCH 3/3] net: phy: mediatek-ge: do not disable EEE advertisement
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2024-03-18 13:08:23
Also in:
linux-mediatek, lkml, netdev
On 3/18/2024 12:46 AM, Arınç ÜNAL via B4 Relay wrote:
From: Arınç ÜNAL <redacted>
There's no need to disable Energy-Efficient Ethernet (EEE) advertisement on
the MT7530 and MT7531 switch PHYs. EEE works fine on MT7530 and MT7531
switch PHYs. Remove the code where EEE advertisement is disabled.
This is a bugfix because there's a possible race condition where the
mediatek-ge driver would kick in after the MT7530 DSA subdriver which would
have EEE disabled until manually enabled.
Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: Arınç ÜNAL <redacted>Could we get Sean to chime in, maybe there was a valid reason to disable EEE advertisement in the first place? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel