Thread (85 messages) 85 messages, 8 authors, 2024-03-27

Re: [PATCH 19/25] ASoC: dt-bindings: meson: axg-sound-card: claim support of A1 SoC family

From: Jerome Brunet <jbrunet@baylibre.com>
Date: 2024-03-15 10:12:57
Also in: alsa-devel, linux-amlogic, linux-clk, linux-devicetree, linux-gpio, linux-sound, lkml

On Fri 15 Mar 2024 at 02:21, Jan Dakinevich [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add "amlogic,a1-sound-card" compatible string alias to
"amlogic,axg-sound-card".

Signed-off-by: Jan Dakinevich <redacted>
---
 .../devicetree/bindings/sound/amlogic,axg-sound-card.yaml   | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml
index 5db718e4d0e7..492b41cc8ccd 100644
--- a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml
+++ b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml
@@ -14,7 +14,11 @@ allOf:
 
 properties:
   compatible:
-    const: amlogic,axg-sound-card
+    oneOf:
+      - const: amlogic,axg-sound-card
+      - items:
+          - const: amlogic,a1-sound-card
+          - const: amlogic,axg-sound-card
I know the rule about SoC related name but it is different here.
This does not describe HW in the SoC. 

The axg sound card is just a name, much like simple-card or
audio-graph-card. I could have named it "amlogic,my-awesome-card"

We would not add "amlogic,a1-simple-card", would we ?

It is purely a software component, which aggregate HW ones.

   audio-aux-devs:
     $ref: /schemas/types.yaml#/definitions/phandle-array

-- 
Jerome

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help