Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg
From: Dan Carpenter <hidden>
Date: 2024-03-13 10:17:45
Also in:
linux-staging, lkml
Normally, I would let Greg decide to notice or ignore the typo in the subject but he's on vacation... s/Kconifg/Kconfig/ On Wed, Mar 13, 2024 at 02:42:59PM +0530, Prasad Pandit wrote:
From: Prasad Pandit <redacted> Add terminating new line to the Kconfig file.
Why does this make a difference? Is it just because it's annoying to cat a file that doesn't have a newline at the end? I checked, and it's not a checkpatch warning. Perhaps it should be though. KTODO: make checkpatch.pl warn about files that don't end in a newline Since you're resending anyway could you add that information to the commit message? Something like: "Add terminating new line to the Kconfig file. Otherwise it's annoying to cat files that don't have a newline. #PetPeeve". Just fix the subject and add a line to the commit message and I'll ack the patch. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel