Re: [PATCH 1/2] media: dt-bindings: media: Add bindings for IMX283
From: Krzysztof Kozlowski <hidden>
Date: 2024-02-16 08:03:52
Also in:
linux-devicetree, linux-media
On 15/02/2024 21:44, Umang Jain wrote:
- Add dt-bindings documentation for Sony IMX283 sensor driver - Add MAINTAINERS entry for Sony IMX283 binding documentation Signed-off-by: Umang Jain <redacted> ---
Due to lack of testing limited review.
quoted hunk ↗ jump to hunk
.../bindings/media/i2c/sony,imx283.yaml | 100 ++++++++++++++++++ MAINTAINERS | 8 ++ 2 files changed, 108 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx283.yamldiff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml new file mode 100644 index 000000000000..3cf46429b282 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml@@ -0,0 +1,100 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2024 Ideas on Board Oy +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx283.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony IMX283 Sensor + +maintainers: + - Kieran Bingham <kieran.bingham@ideasonboard.com> + - Umang Jain <umang.jain@ideasonboard.com> + +description: + IMX283 sensor is a Sony CMOS active pixel digital image sensor with an active + array size of 5472H x 3648V. It is programmable through I2C interface. The + I2C client address is fixed to 0x1a as per sensor data sheet. Image data is + sent through MIPI CSI-2. + +properties: + compatible: + const: sony,imx283
Blank line
+ reg: + description: I2C address
Drop description
+ maxItems: 1 + + assigned-clocks: true + assigned-clock-parents: true + assigned-clock-rates: true
Drop all three, not really needed, just mention them in example.
+ + clocks: + description: Clock frequency from 6 to 24 MHz. + maxItems: 1 + + vana-supply: + description: Analog power supply (2.9V) + + vdig-supply: + description: Interface power supply (1.8V) + + vddl-supply: + description: Digital power supply (1.2V) + + port: + additionalProperties: false + $ref: /schemas/graph.yaml#/$defs/port-base
Please reverse above lines, first ref, then additionalprops.
+ + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false
Ditto
+ + properties: + data-lanes: true
Provide constraints - which lanes/how many.
+ link-frequencies: true + + required: + - data-lanes + - link-frequencies + + required: + - endpoint + +required: + - compatible + - reg + - clocks + - port + +additionalProperties: false +
Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel