Re: [PATCH v4 00/20] Support more Amlogic SoC families in crypto driver
From: Alexey Romanov <hidden>
Date: 2024-02-29 13:05:22
Also in:
linux-amlogic, linux-crypto, linux-devicetree, lkml
Hello! On Wed, Feb 28, 2024 at 09:19:32PM +0100, Corentin Labbe wrote:
Le Wed, Feb 28, 2024 at 01:37:02PM +0000, Alexey Romanov a 'ecrit :quoted
Hello, On Mon, Feb 19, 2024 at 07:57:27AM +0100, Corentin Labbe wrote:quoted
Le Thu, Feb 15, 2024 at 10:47:24AM +0000, Alexey Romanov a 'ecrit :quoted
On Tue, Feb 13, 2024 at 08:21:12AM +0100, Corentin Labbe wrote:quoted
Le Mon, Feb 12, 2024 at 04:50:48PM +0300, Alexey Romanov a 'ecrit :quoted
Hello! This patchset expand the funcionality of the Amlogic crypto driver by adding support for more SoC families: AXG, G12A, G12B, SM1, A1, S4. Also specify and enable crypto node in device tree for reference Amlogic devices. Tested on AXG, G12A/B, SM1, A1 and S4 devices via custom tests [1] and tcrypt module. ---added patchs up to "drivers: crypto: meson: process more than MAXDESCS descriptors"Including this patch or not?The crash start with "drivers: crypto: meson: move algs definition and cipher API to cipher.c"Unfortunately I was unable to reproduce this. I use Khadas Vim1 board and my custom tests (https://gist.github.com/mRrvz/3fb8943a7487ab7b943ec140706995e7). Tried both build as module and built-in. Can you, please, give more information? Maybe your test cases?My test case is simple, simply load the driver. The problem is that you moved the algs[i].mc = mc after the register of algs (in drivers: crypto: meson: move algs definition and cipher API to cipher.c) Test could happen as soon the register is done and so mc is deferenced.
Yeah, you are right. Will fix it. Thank you.
Since you didnt hit the case, I suspect you didnt test the driver as module.
No, I test the driver as module. I think the problem is that on my system no one uses this crypto backend outside of my tests module, unlike your system.
Regards
-- Thank you, Alexey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel