Re: [PATCH v6 2/2] media: i2c: Add GC08A3 image sensor driver

Hi Andy,

On Tue, Feb 27, 2024 at 02:46:54PM +0200, Andy Shevchenko wrote:

On Tue, Feb 27, 2024 at 3:33 AM Zhi Mao [off-list ref] wrote:

quoted

Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor.

...

quoted

+/*
+ * gc08a3.c - gc08a3 sensor driver

Drop the filename from the file, it's impractical (esp. if the file
will be renamed for some reason in the future).

quoted

+ *
+ * Copyright 2023 MediaTek

You could update the year.

...

quoted

+       endpoint =
+               fwnode_graph_get_endpoint_by_id(dev_fwnode(dev), 0, 0,
+                                               FWNODE_GRAPH_ENDPOINT_NEXT);
+       if (!endpoint) {

Strictly speaking dev_fwnode(dev) might be NULL or an error pointer. I
dunno how the graph is implemented there and if it's possible to get
an error pointer out of it. At least this probably needs to be aligned
there at some point.

This is fine---the fwnode API returns errors (for functions that can) for
NULL or error pointer fwnodes.

The patches are in my tree already, please post a patch on top of this that
I can squash.

-- 
Regards,

Sakari Ailus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel