Re: [PATCH 1/4] clk: rockchip: rst-rk3588: Add BIU reset
From: Nicolas Dufresne <hidden>
Date: 2024-02-16 19:29:59
Also in:
linux-clk, linux-devicetree, linux-media, linux-rockchip, lkml
Le vendredi 16 février 2024 à 11:03 +0100, Krzysztof Kozlowski a écrit :
On 16/02/2024 10:49, Shreeya Patel wrote:quoted
Export hdmirx_biu soft reset id which is required by the hdmirx controller. Signed-off-by: Shreeya Patel <redacted> --- drivers/clk/rockchip/rst-rk3588.c | 1 + include/dt-bindings/reset/rockchip,rk3588-cru.h | 2 ++Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please do internal review. The internal Collabora review would tell you: YOU MUST run checkpatch. Then you see errors, so why do you send patch with errors to the mailing list?
Mistakes helps you learn. Meanwhile, I've triggered our temporary CI which hopefully will catch this and some more for a better v2. Shreeya, I don't think this includes any DT automated checks, this is on you. https://gitlab.collabora.com/linux/build-scripts/-/pipelines/85935
Best regards, Krzysztof
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel