Re: [PATCH 05/23] gpio: nomadik: extract GPIO platform driver from drivers/pinctrl/nomadik/
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: 2024-02-15 10:03:36
Also in:
linux-devicetree, linux-gpio, linux-mips, lkml
On Mi, 2024-02-14 at 17:23 +0100, Théo Lebrun wrote: [...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c new file mode 100644 index 000000000000..e39477e1a58f --- /dev/null +++ b/drivers/gpio/gpio-nomadik.c@@ -0,0 +1,660 @@
[...]
+static int nmk_gpio_probe(struct platform_device *dev)
+{[...]
+ ret = gpiochip_add_data(chip, nmk_chip);
Use devm_gpiochip_add_data() to cleanup on unbind, before nmk_chip goes away. Or make the driver un-unbindable via suppress_bind_attrs. In that case you could drop devm_ prefixes everywhere for consistency. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel