Re: [PATCH 1/4] spi: s3c64xx: explicitly include <linux/types.h>
From: Tudor Ambarus <tudor.ambarus@linaro.org>
Date: 2024-02-07 10:14:55
Also in:
linux-devicetree, linux-samsung-soc, linux-spi, lkml
On 2/7/24 09:58, Greg Kroah-Hartman wrote:
On Wed, Feb 07, 2024 at 06:20:56AM +0000, Tudor Ambarus wrote:quoted
On 2/6/24 18:02, Sam Protsenko wrote:quoted
On Tue, Feb 6, 2024 at 2:52 AM Tudor Ambarus [off-list ref] wrote:quoted
The driver uses u32 and relies on an implicit inclusion of <linux/types.h>. It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver")Not sure if Fixes tag is needed here.We have already talked about this. If a patch that causes the implicit include to vanish is backported to stable, it will reveal the missing header here and will result in backporting this patch as well.So worry about this then, not now.quoted
So, as a good practice let's allow this patch to be queued to stable, it will avoid possible compilation errors."possible" does not mean "needed". Please only tag stuff that you know is needed, if the stable developers break things, they can fix it up when it happens. Adding .h includes is not a fixes: thing unless it actually fixes something in Linus's tree, otherwise it's an abuse of the tag. Please don't do that.
Okay, thanks for the clarification. Cheers, ta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel