Thread (23 messages) 23 messages, 3 authors, 2024-02-07

Re: [PATCH v4 02/16] spi: s3c64xx: explicitly include <linux/bits.h>

From: Peter Griffin <peter.griffin@linaro.org>
Date: 2024-02-05 15:25:29
Also in: linux-samsung-soc, linux-spi, lkml

On Mon, 5 Feb 2024 at 12:45, Tudor Ambarus [off-list ref] wrote:
The driver uses GENMASK() but does not include <linux/bits.h>.

It is good practice to directly include all headers used, it avoids
implicit dependencies and spurious breakage if someone rearranges
headers and causes the implicit include to vanish.

Include the missing header.

Fixes: 1224e29572f6 ("spi: s3c64xx: Fix large transfers with DMA")
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help