Re: [PATCH v3] spi: imx: fix the burst length at DMA mode and CPU mode
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2024-02-01 10:06:12
Also in:
linux-spi, lkml
On 01.02.2024 18:01:15, carlos.song@nxp.com wrote:
quoted hunk ↗ jump to hunk
From: Carlos Song <redacted> For DMA mode, the bus width of the DMA is equal to the size of data word, so burst length should be configured as bits per word. For CPU mode, because of the spi transfer len is in byte, so burst length should be configured as bits per byte * spi_imx->count. Signed-off-by: Carlos Song <redacted> Reviewed-by: Clark Wang <xiaoning.wang@nxp.com> Fixes: e9b220aeacf1 ("spi: spi-imx: correctly configure burst length when using dma") Fixes: 5f66db08cbd3 ("spi: imx: Take in account bits per word instead of assuming 8-bits") --- Changes for V3: - include <linux/bits.h> --- drivers/spi/spi-imx.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 546cdce525fc..2a1ae7b00760 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c@@ -21,7 +21,7 @@ #include <linux/types.h> #include <linux/of.h> #include <linux/property.h> - +#include <linux/bits.h>
nitpick: Please keep the includes sorted alphabetically.
#include <linux/dma/imx-dma.h>
Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel