Re: [PATCH net-next v2 1/7] net: phy: add PHY_F_RXC_ALWAYS_ON to PHY dev flags
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2024-01-30 14:02:50
Also in:
linux-renesas-soc, netdev
On Tue, Jan 30, 2024 at 02:55:50PM +0100, Andrew Lunn wrote:
quoted
@@ -768,6 +768,7 @@ struct phy_device { /* Generic phy_device::dev_flags */ #define PHY_F_NO_IRQ 0x80000000 +#define PHY_F_RXC_ALWAYS_ON BIT(30)It is a bit odd mixing 0x numbers and BIT() macros for the same class of thing. I would use 0x40000000, or convert PHY_F_NO_IRQ to BIT(31)
If I used 0x40000000, there would be review comments suggesting the use of BIT(). Can't win! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel