Re: [PATCH net 5/5] net: pcs: rzn1-miic: Init RX clock early if MAC requires it

From
Romain Gantois <romain.gantois@bootlin.com>
Date
2024-01-03 15:45:57
Also in
linux-renesas-soc, netdev
Reply to
Russell King (Oracle), 2024-01-03
Hello Russel,

On Wed, 3 Jan 2024, Russell King (Oracle) wrote:
...
Since the MAC driver has to itself provide the PCS to phylink via the
mac_select_pcs() method, the MAC driver already has knowledge of which
PCS it is going to be using. Therefore, I think it may make sense
to do something like this:

int phylink_pcs_preconfig(struct phylink *pl, struct phylink_pcs *pcs)
{
	if (pl->config->mac_requires_rxc)
		pcs->rxc_always_on = true;

	if (pcs->ops->preconfig)
		pcs->ops->pcs_preconfig(pcs);
}

and have stmmac call phylink_pcs_preconfig() for each PCS that it will
be using during initialisation / resume paths?
Yes, that is definitely a much cleaner solution. I'll reimplement the PCS 
changes in this way.

Best Regards,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (10 messages) 10 messages, 3 authors, last reply 2024-01-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help