Thread (4 messages) 4 messages, 3 authors, 2024-01-31

Re: [PATCH 30 1/7] Add JTAG core driver

From: "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>
Date: 2024-01-30 23:43:18
Also in: linux-aspeed, linux-doc, lkml

On Tue, Jan 30, 2024 at 11:26:19PM +0000, Corona, Ernesto wrote:
+/**
+ * union pad_config - Padding Configuration:
+ *
+ * @type: transfer type
+ * @pre_pad_number: Number of prepadding bits bit[11:0]
+ * @post_pad_number: Number of prepadding bits bit[23:12]
+ * @pad_data : Bit value to be used by pre and post padding bit[24]
+ * @int_value: unsigned int packed padding configuration value bit[32:0]
+ *
+ * Structure provide pre and post padding configuration in a single __u32
+ */
+union pad_config {
Bad name for a global structure, don't you think?
+	struct {
+		__u32 pre_pad_number	: 12;
+		__u32 post_pad_number	: 12;
+		__u32 pad_data		: 1;
+		__u32 rsvd		: 7;
+	};
This obviously does not work, please don't do that.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help