[PATCH 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status
STALE984d
From: Aren Moynihan <hidden>
Date: 2024-01-28 20:48:50
Also in:
linux-devicetree, linux-sunxi, lkml
Subsystem:
arm/allwinner sunxi soc support, the rest · Maintainers:
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Linus Torvalds
The status function is described in the documentation as being a rgb led used for system notifications on phones[1][2]. This is exactly what this led is used for on the PinePhone, so using status is probably more accurate than indicator. 1: Documentation/leds/well-known-leds.txt 2: include/dt-bindings/leds/common.h Signed-off-by: Aren Moynihan <redacted> --- I can't find any documentation describing the indicator function, so it's definitely less specific than status, but besides that I'm not sure how it compares. Please ignore this patch if it's not useful and/or just causing churn. arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
index 6eab61a12cd8..4f39cfeb13ec 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi@@ -40,21 +40,21 @@ leds { compatible = "gpio-leds"; led0: led-0 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; led1: led-1 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_GREEN>; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; led2: led-2 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_RED>; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ retain-state-suspended;
@@ -64,7 +64,7 @@ led2: led-2 { multi-led { compatible = "leds-group-multicolor"; color = <LED_COLOR_ID_RGB>; - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; leds = <&led0>, <&led1>, <&led2>; };
--
2.43.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel