Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer

On Mon, Jan 22, 2024 at 07:31:18PM +0000, Daniel Golle wrote:

Hi Breno,

On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:

quoted

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LynxI PCS MediaTek's SoC.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/pcs/pcs-lynx.c      | 1 +
 drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
 drivers/net/pcs/pcs-xpcs.c      | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
index dc3962b2aa6b..d51d09beaab3 100644
--- a/drivers/net/pcs/pcs-lynx.c
+++ b/drivers/net/pcs/pcs-lynx.c

@@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
 }
 EXPORT_SYMBOL(lynx_pcs_destroy);
 
+MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");

Nah, pcs-lynx.c is used by various SoC vendors **other than MediaTek**
such as Freescale and STMicroelectronics.

Users of the pcs-lynx.c driver are
ethernet/stmicro/stmmac/dwmac-socfpga.c
ethernet/altera/altera_tse_main.c
ethernet/freescale/dpaa2/dpaa2-mac.c
ethernet/freescale/enetc/enetc_pf.c
ethernet/freescale/fman/fman_memac.c
dsa/ocelot/felix_vsc9959.c
dsa/ocelot/seville_vsc9953.c

Thanks. What about something as?

MODULE_DESCRIPTION("Lynx PCS MDIO helpers");


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel